| Commit message (Collapse) | Author | Age |
|---|
| |
|
|
|
|
| |
The `jsdom` upgrade entails upgrading Node, as something changed internally to jsdom in how it imports other modules.
Upgrading vitest caused the details of some of our test cases to change, but the semantics of the affected tests are the same. They also split resetting mocks from resetting mocks' behaviours, which required a small config change to preserve our tests' correctness.
|
| | |
|
| |
|
|
| |
These values were drawn from `npx vitest --run --coverage` as of this commit. I offer no opinion on whether they are _desireable_ coverage thresholds, only that they are what we are actually achieving, and what we are accepting in practice.
|
| |
|
|
|
|
|
|
| |
Access to "global" (maybe "external?") state is now handled at the top level of the component hierarchy, in `+page.svelte`, `+layout.svelte`, and their associated scripts. State is otherwise passed down through props, and changes are passed up through callbacks.
This is - hopefully - groundwork for refactoring state management a bit. I wanted to move access to state out to a smaller number of places, so that I have fewer places to update to implement reconnect logic. My broader goal is to make it easier to refactor these kinds of external side effects, as well, though no such changes are in this branch.
This change also makes testing a mile easier, since tests can interact with props and callbacks instead of emulating the whole HTTP request stack and the Pilcrow API. This change removes do-very-little tests.
|
| |
|
|
| |
Just basic "will it mount?" tests for more components.
|
| |
|
|
|
|
|
|
|
|
| |
Turns out a number of our components are a pain to run via a mounting
test, but Svelte does suggest that this is the dispreferred way to test
anyway. Using use:, triggering navigation after logout, and
scrollIntoView all make the headless node test process with the janky
in-memory mount have a Very Bad Day.
But this is still progress! We will press on.
|
| | |
|
| | |
|
| | |
|
| |
|
