From 60b711c844f8624348d5d1dac3a625532a8e2a82 Mon Sep 17 00:00:00 2001 From: Owen Jacobson Date: Fri, 27 Sep 2024 23:03:46 -0400 Subject: Delete expired messages out of band. Trying to reliably do expiry mid-request was causing some anomalies: * Creating a channel with a dup name would fail, then succeed after listing channels. It was very hard to reason about which operations needed to trigger expiry, to fix this "correctly," so now expiry runs on every request. --- src/channel/routes/test/on_create.rs | 2 +- src/channel/routes/test/on_send.rs | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) (limited to 'src/channel') diff --git a/src/channel/routes/test/on_create.rs b/src/channel/routes/test/on_create.rs index bb6697f..5e62d7f 100644 --- a/src/channel/routes/test/on_create.rs +++ b/src/channel/routes/test/on_create.rs @@ -38,7 +38,7 @@ async fn new_channel() { let mut events = app .events() - .subscribe(&fixtures::now(), types::ResumePoint::default()) + .subscribe(types::ResumePoint::default()) .await .expect("subscribing never fails") .filter(|types::ResumableEvent(_, event)| future::ready(event.channel == response_channel)); diff --git a/src/channel/routes/test/on_send.rs b/src/channel/routes/test/on_send.rs index 20ae016..233518b 100644 --- a/src/channel/routes/test/on_send.rs +++ b/src/channel/routes/test/on_send.rs @@ -41,12 +41,12 @@ async fn messages_in_order() { // Verify the semantics - let subscribed_at = fixtures::now(); let events = app .events() - .subscribe(&subscribed_at, types::ResumePoint::default()) + .subscribe(types::ResumePoint::default()) .await .expect("subscribing to a valid channel") + .filter(fixtures::filter::messages()) .take(requests.len()); let events = events.collect::>().immediately().await; -- cgit v1.2.3