From 1a0ee4af6538b5486d35730d480d00ca4d9edafb Mon Sep 17 00:00:00 2001
From: Owen Jacobson <owen@grimoire.ca>
Date: Sun, 24 Aug 2025 03:32:21 -0400
Subject: Stop returning body data from `POST /api/setup`.

This API response was always ad-hoc, and the client doesn't use it. To free up some maneuvering room for server refactorings, stop sending it. We can add a response in the future if there's a need.
---
 src/setup/app.rs | 11 ++++-------
 1 file changed, 4 insertions(+), 7 deletions(-)

(limited to 'src/setup/app.rs')

diff --git a/src/setup/app.rs b/src/setup/app.rs
index 1210175..123cff9 100644
--- a/src/setup/app.rs
+++ b/src/setup/app.rs
@@ -7,10 +7,7 @@ use crate::{
     name::Name,
     password::Password,
     token::{Secret, repo::Provider as _},
-    user::{
-        User,
-        create::{self, Create},
-    },
+    user::create::{self, Create},
 };
 
 pub struct Setup<'a> {
@@ -28,7 +25,7 @@ impl<'a> Setup<'a> {
         name: &Name,
         password: &Password,
         created_at: &DateTime,
-    ) -> Result<(User, Secret), Error> {
+    ) -> Result<Secret, Error> {
         let create = Create::begin(name, password, created_at);
 
         let validated = create.validate()?;
@@ -42,9 +39,9 @@ impl<'a> Setup<'a> {
         let secret = tx.tokens().issue(stored.user(), created_at).await?;
         tx.commit().await?;
 
-        let user = stored.publish(self.events);
+        let _ = stored.publish(self.events);
 
-        Ok((user.as_created(), secret))
+        Ok(secret)
     }
 
     pub async fn completed(&self) -> Result<bool, sqlx::Error> {
-- 
cgit v1.2.3


From ee9812bd35409abe9532b1d508e04c1dae63c941 Mon Sep 17 00:00:00 2001
From: Owen Jacobson <owen@grimoire.ca>
Date: Sun, 24 Aug 2025 04:01:13 -0400
Subject: Remove the now-unused return value from the final stage of user
 creation.

---
 src/invite/app.rs  | 2 +-
 src/setup/app.rs   | 2 +-
 src/user/app.rs    | 3 ++-
 src/user/create.rs | 5 +----
 4 files changed, 5 insertions(+), 7 deletions(-)

(limited to 'src/setup/app.rs')

diff --git a/src/invite/app.rs b/src/invite/app.rs
index 14c1440..1c85562 100644
--- a/src/invite/app.rs
+++ b/src/invite/app.rs
@@ -74,7 +74,7 @@ impl<'a> Invites<'a> {
         let secret = tx.tokens().issue(stored.user(), accepted_at).await?;
         tx.commit().await?;
 
-        let _ = stored.publish(self.events);
+        stored.publish(self.events);
 
         Ok(secret)
     }
diff --git a/src/setup/app.rs b/src/setup/app.rs
index 123cff9..1856519 100644
--- a/src/setup/app.rs
+++ b/src/setup/app.rs
@@ -39,7 +39,7 @@ impl<'a> Setup<'a> {
         let secret = tx.tokens().issue(stored.user(), created_at).await?;
         tx.commit().await?;
 
-        let _ = stored.publish(self.events);
+        stored.publish(self.events);
 
         Ok(secret)
     }
diff --git a/src/user/app.rs b/src/user/app.rs
index 5f58981..301c39c 100644
--- a/src/user/app.rs
+++ b/src/user/app.rs
@@ -29,7 +29,8 @@ impl<'a> Users<'a> {
         let stored = validated.store(&mut tx).await?;
         tx.commit().await?;
 
-        let user = stored.publish(self.events);
+        let user = stored.user().to_owned();
+        stored.publish(self.events);
 
         Ok(user.as_created())
     }
diff --git a/src/user/create.rs b/src/user/create.rs
index 0e7a118..5d7bf65 100644
--- a/src/user/create.rs
+++ b/src/user/create.rs
@@ -73,13 +73,10 @@ pub struct Stored {
 }
 
 impl Stored {
-    #[must_use = "dropping a user creation attempt is likely a mistake"]
-    pub fn publish(self, events: &Broadcaster) -> History {
+    pub fn publish(self, events: &Broadcaster) {
         let Self { user } = self;
 
         events.broadcast(user.events().map(Event::from).collect::<Vec<_>>());
-
-        user
     }
 
     pub fn user(&self) -> &History {
-- 
cgit v1.2.3