From ad00b553d845dba8af7b0e9fa2930209aee1dd62 Mon Sep 17 00:00:00 2001
From: Owen Jacobson <owen@grimoire.ca>
Date: Sat, 19 Oct 2024 00:57:20 -0400
Subject: Make the responses for various data creation requests more
 consistent.

In general:

* If the client can only assume the response is immediately valid (mostly, login creation, where the client cannot monitor the event stream), then 200 Okay, with data describing the server's view of the request.

* If the client can monitor for completion by watching the event stream, then 202 Accepted, with data describing the server's view of the request.

This comes on the heels of a comment I made on Discord:

> hrm
>
> creating a login: 204 No Content, no body
> sending a message: 202 Accepted, no body
> creating a channel: 200 Okay, has a body
>
> past me, what were you on

There wasn't any principled reason for this inconsistency; it happened as the endpoints were written at different times and with different states of mind.
---
 src/test/fixtures/identity.rs | 12 ++++++------
 src/test/fixtures/login.rs    |  7 ++++---
 2 files changed, 10 insertions(+), 9 deletions(-)

(limited to 'src/test/fixtures')

diff --git a/src/test/fixtures/identity.rs b/src/test/fixtures/identity.rs
index 56b4ffa..c434473 100644
--- a/src/test/fixtures/identity.rs
+++ b/src/test/fixtures/identity.rs
@@ -3,7 +3,7 @@ use uuid::Uuid;
 use crate::{
     app::App,
     clock::RequestedAt,
-    login::Password,
+    login::{Login, Password},
     token::{
         extract::{Identity, IdentityToken},
         Secret,
@@ -14,11 +14,11 @@ pub fn not_logged_in() -> IdentityToken {
     IdentityToken::new()
 }
 
-pub async fn logged_in(app: &App, login: &(String, Password), now: &RequestedAt) -> IdentityToken {
-    let (name, password) = login;
-    let token = app
+pub async fn logged_in(app: &App, login: &(Login, Password), now: &RequestedAt) -> IdentityToken {
+    let (login, password) = login;
+    let (_, token) = app
         .tokens()
-        .login(name, password, now)
+        .login(&login.name, password, now)
         .await
         .expect("should succeed given known-valid credentials");
 
@@ -36,7 +36,7 @@ pub async fn from_token(app: &App, token: &IdentityToken, issued_at: &RequestedA
     Identity { token, login }
 }
 
-pub async fn identity(app: &App, login: &(String, Password), issued_at: &RequestedAt) -> Identity {
+pub async fn identity(app: &App, login: &(Login, Password), issued_at: &RequestedAt) -> Identity {
     let secret = logged_in(app, login, issued_at).await;
     from_token(app, &secret, issued_at).await
 }
diff --git a/src/test/fixtures/login.rs b/src/test/fixtures/login.rs
index e5ac716..b6766fe 100644
--- a/src/test/fixtures/login.rs
+++ b/src/test/fixtures/login.rs
@@ -7,14 +7,15 @@ use crate::{
     login::{self, Login, Password},
 };
 
-pub async fn create_with_password(app: &App, created_at: &RequestedAt) -> (String, Password) {
+pub async fn create_with_password(app: &App, created_at: &RequestedAt) -> (Login, Password) {
     let (name, password) = propose();
-    app.logins()
+    let login = app
+        .logins()
         .create(&name, &password, created_at)
         .await
         .expect("should always succeed if the login is actually new");
 
-    (name, password)
+    (login, password)
 }
 
 pub async fn create(app: &App, created_at: &RequestedAt) -> Login {
-- 
cgit v1.2.3