From 4e3d5ccac99b24934c972e088cd7eb02bb95df06 Mon Sep 17 00:00:00 2001 From: Owen Jacobson Date: Tue, 17 Jun 2025 02:11:45 -0400 Subject: Handlers are _named operations_, which can be exposed via routes. Each domain module that exposes handlers does so through a `handlers` child module, ideally as a top-level symbol that can be plugged directly into Axum's `MethodRouter`. Modules could make exceptions to this - kill the doctrinaire inside yourself, after all - but none of the API modules that actually exist need such exceptions, and consistency is useful. The related details of request types, URL types, response types, errors, &c &c are then organized into modules under `handlers`, along with their respective tests. --- src/ui/routes/invite/invite.rs | 55 ------------------------------------------ src/ui/routes/invite/mod.rs | 4 --- 2 files changed, 59 deletions(-) delete mode 100644 src/ui/routes/invite/invite.rs delete mode 100644 src/ui/routes/invite/mod.rs (limited to 'src/ui/routes/invite') diff --git a/src/ui/routes/invite/invite.rs b/src/ui/routes/invite/invite.rs deleted file mode 100644 index 06e5792..0000000 --- a/src/ui/routes/invite/invite.rs +++ /dev/null @@ -1,55 +0,0 @@ -pub mod get { - use axum::{ - extract::{Path, State}, - response::{self, IntoResponse}, - }; - - use crate::{ - app::App, - error::Internal, - invite, - ui::{ - assets::{Asset, Assets}, - error::NotFound, - }, - }; - - pub async fn handler( - State(app): State, - Path(invite): Path, - ) -> Result { - app.invites() - .get(&invite) - .await - .map_err(Error::internal)? - .ok_or(Error::NotFound)?; - - Assets::index().map_err(Error::Internal) - } - - #[derive(Debug, thiserror::Error)] - pub enum Error { - #[error("invite not found")] - NotFound, - #[error("{0}")] - Internal(Internal), - } - - impl Error { - fn internal(err: impl Into) -> Self { - Self::Internal(err.into()) - } - } - - impl IntoResponse for Error { - fn into_response(self) -> response::Response { - match self { - Self::NotFound => match Assets::index() { - Ok(asset) => NotFound(asset).into_response(), - Err(internal) => internal.into_response(), - }, - Self::Internal(error) => error.into_response(), - } - } - } -} diff --git a/src/ui/routes/invite/mod.rs b/src/ui/routes/invite/mod.rs deleted file mode 100644 index 50af8be..0000000 --- a/src/ui/routes/invite/mod.rs +++ /dev/null @@ -1,4 +0,0 @@ -// In this case, the first redundant `invite` is a literal path segment, and the -// second `invite` reflects a placeholder. -#[allow(clippy::module_inception)] -pub mod invite; -- cgit v1.2.3