From 4e3d5ccac99b24934c972e088cd7eb02bb95df06 Mon Sep 17 00:00:00 2001
From: Owen Jacobson <owen@grimoire.ca>
Date: Tue, 17 Jun 2025 02:11:45 -0400
Subject: Handlers are _named operations_, which can be exposed via routes.

Each domain module that exposes handlers does so through a `handlers` child module, ideally as a top-level symbol that can be plugged directly into Axum's `MethodRouter`. Modules could make exceptions to this - kill the doctrinaire inside yourself, after all - but none of the API modules that actually exist need such exceptions, and consistency is useful.

The related details of request types, URL types, response types, errors, &c &c are then organized into modules under `handlers`, along with their respective tests.
---
 src/user/routes/login/test.rs | 128 ------------------------------------------
 1 file changed, 128 deletions(-)
 delete mode 100644 src/user/routes/login/test.rs

(limited to 'src/user/routes/login/test.rs')

diff --git a/src/user/routes/login/test.rs b/src/user/routes/login/test.rs
deleted file mode 100644
index d2e7ee2..0000000
--- a/src/user/routes/login/test.rs
+++ /dev/null
@@ -1,128 +0,0 @@
-use axum::extract::{Json, State};
-
-use super::post;
-use crate::{test::fixtures, token::app};
-
-#[tokio::test]
-async fn correct_credentials() {
-    // Set up the environment
-
-    let app = fixtures::scratch_app().await;
-    let (name, password) = fixtures::user::create_with_password(&app, &fixtures::now()).await;
-
-    // Call the endpoint
-
-    let identity = fixtures::cookie::not_logged_in();
-    let logged_in_at = fixtures::now();
-    let request = post::Request {
-        name: name.clone(),
-        password,
-    };
-    let (identity, Json(response)) =
-        post::handler(State(app.clone()), logged_in_at, identity, Json(request))
-            .await
-            .expect("logged in with valid credentials");
-
-    // Verify the return value's basic structure
-
-    assert_eq!(name, response.name);
-    let secret = identity
-        .secret()
-        .expect("logged in with valid credentials issues an identity cookie");
-
-    // Verify the semantics
-
-    let validated_at = fixtures::now();
-    let (_, validated_login) = app
-        .tokens()
-        .validate(&secret, &validated_at)
-        .await
-        .expect("identity secret is valid");
-
-    assert_eq!(response, validated_login);
-}
-
-#[tokio::test]
-async fn invalid_name() {
-    // Set up the environment
-
-    let app = fixtures::scratch_app().await;
-
-    // Call the endpoint
-
-    let identity = fixtures::cookie::not_logged_in();
-    let logged_in_at = fixtures::now();
-    let (name, password) = fixtures::user::propose();
-    let request = post::Request {
-        name: name.clone(),
-        password,
-    };
-    let post::Error(error) =
-        post::handler(State(app.clone()), logged_in_at, identity, Json(request))
-            .await
-            .expect_err("logged in with an incorrect password fails");
-
-    // Verify the return value's basic structure
-
-    assert!(matches!(error, app::LoginError::Rejected));
-}
-
-#[tokio::test]
-async fn incorrect_password() {
-    // Set up the environment
-
-    let app = fixtures::scratch_app().await;
-    let login = fixtures::user::create(&app, &fixtures::now()).await;
-
-    // Call the endpoint
-
-    let logged_in_at = fixtures::now();
-    let identity = fixtures::cookie::not_logged_in();
-    let request = post::Request {
-        name: login.name,
-        password: fixtures::user::propose_password(),
-    };
-    let post::Error(error) =
-        post::handler(State(app.clone()), logged_in_at, identity, Json(request))
-            .await
-            .expect_err("logged in with an incorrect password");
-
-    // Verify the return value's basic structure
-
-    assert!(matches!(error, app::LoginError::Rejected));
-}
-
-#[tokio::test]
-async fn token_expires() {
-    // Set up the environment
-
-    let app = fixtures::scratch_app().await;
-    let (name, password) = fixtures::user::create_with_password(&app, &fixtures::now()).await;
-
-    // Call the endpoint
-
-    let logged_in_at = fixtures::ancient();
-    let identity = fixtures::cookie::not_logged_in();
-    let request = post::Request { name, password };
-    let (identity, _) = post::handler(State(app.clone()), logged_in_at, identity, Json(request))
-        .await
-        .expect("logged in with valid credentials");
-    let secret = identity.secret().expect("logged in with valid credentials");
-
-    // Verify the semantics
-
-    let expired_at = fixtures::now();
-    app.tokens()
-        .expire(&expired_at)
-        .await
-        .expect("expiring tokens never fails");
-
-    let verified_at = fixtures::now();
-    let error = app
-        .tokens()
-        .validate(&secret, &verified_at)
-        .await
-        .expect_err("validating an expired token");
-
-    assert!(matches!(error, app::ValidateError::InvalidToken));
-}
-- 
cgit v1.2.3