diff options
| author | Owen Jacobson <owen@grimoire.ca> | 2025-05-05 23:12:22 -0400 |
|---|---|---|
| committer | Owen Jacobson <owen@grimoire.ca> | 2025-05-05 23:14:57 -0400 |
| commit | 84c1fa7ccef4e8e49f17d643f360ec0f184683fb (patch) | |
| tree | 697a2f2c4f7f2b04f581023d82212c4c74877920 /ui/fonts/RobotoCondensed-LightItalic.ttf | |
| parent | d11ff421de581a835f1645b22d1f7f4304640b0c (diff) | |
Don't retry operations where we received an unacceptable response.
This was actually two issues in one!
Issue 1: `isRetryable` did not consider whether we got a response or not. It assumed that the presence of a request in the error signaled that the error was definitely due to network issues, when in fact it's the presence of a request _and_ the absence of a response. That's my misreading of the Axios docs; the replacement `isRetryable` is more thorough.
Issue 2: operations in the outbox queue that fail with an exception stop the outbox drain process from making further progress, _and_ they stay in the queue. The outbox now dequeues jobs that throw an exception, and restarts itself if it terminates with a non-empty queue. The code that does this is _heinous_, but it seems to work well enough… Words I'm sure I won't come to regret.
Diffstat (limited to 'ui/fonts/RobotoCondensed-LightItalic.ttf')
0 files changed, 0 insertions, 0 deletions
