Hoist global state access out of individual components.

Access to "global" (maybe "external?") state is now handled at the top level of the component hierarchy, in `+page.svelte`, `+layout.svelte`, and their associated scripts. State is otherwise passed down through props, and changes are passed up through callbacks.

This is - hopefully - groundwork for refactoring state management a bit. I wanted to move access to state out to a smaller number of places, so that I have fewer places to update to implement reconnect logic. My broader goal is to make it easier to refactor these kinds of external side effects, as well, though no such changes are in this branch.

This change also makes testing a mile easier, since tests can interact with props and callbacks instead of emulating the whole HTTP request stack and the Pilcrow API. This change removes do-very-little tests.

1 files changed, 25 insertions, 13 deletions

diff --git a/ui/tests/lib/components/LogIn.svelte.test.js b/ui/tests/lib/components/LogIn.svelte.test.js
index b64d846..ab77c11 100644
--- a/ui/tests/lib/components/LogIn.svelte.test.js
+++ b/ui/tests/lib/components/LogIn.svelte.test.js
@@ -1,22 +1,34 @@
-import { flushSync, mount, unmount } from 'svelte';
-import { afterEach, beforeEach, describe, expect, test } from 'vitest';
+import { render, screen } from '@testing-library/svelte';
+import userEvent from '@testing-library/user-event';
+import { beforeEach, expect, test, describe, it, vi } from 'vitest';
 import LogIn from '$lib/components/LogIn.svelte';
 
-let component;
+const user = userEvent.setup();
 
-describe('LogIn', () => {
-  beforeEach(() => {
-    component = mount(LogIn, {
-      target: document.body // `document` exists because of jsdom
+const mocks = vi.hoisted(() => ({
+  logIn: vi.fn()
+}));
+
+describe('LogIn', async () => {
+  beforeEach(async () => {
+    render(LogIn, {
+      logIn: mocks.logIn
     });
-    flushSync();
   });
 
-  afterEach(() => {
-    unmount(component);
-  });
+  it('sends a login request', async () => {
+    const username = screen.getByLabelText('username');
+    await user.type(username, 'my username');
+
+    const password = screen.getByLabelText('password');
+    await user.type(password, 'my very creative and long password');
+
+    const signIn = screen.getByRole('button');
+    await user.click(signIn);
 
-  test('mounts', async () => {
-    expect(component).toBeTruthy();
+    expect(mocks.logIn).toHaveBeenCalledExactlyOnceWith(
+      'my username',
+      'my very creative and long password'
+    );
   });
 });