1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
|
use axum::extract::State;
use axum_extra::extract::Query;
use futures::{
future,
stream::{self, StreamExt as _},
};
use super::get;
use crate::{
event::Sequenced as _,
test::fixtures::{self, future::Immediately as _},
};
#[tokio::test]
async fn includes_historical_message() {
// Set up the environment
let app = fixtures::scratch_app().await;
let sender = fixtures::login::create(&app, &fixtures::now()).await;
let channel = fixtures::channel::create(&app, &fixtures::now()).await;
let message = fixtures::message::send(&app, &channel, &sender, &fixtures::now()).await;
// Call the endpoint
let subscriber_creds = fixtures::login::create_with_password(&app, &fixtures::now()).await;
let subscriber = fixtures::identity::identity(&app, &subscriber_creds, &fixtures::now()).await;
let get::Response(events) = get::handler(State(app), subscriber, None, Query::default())
.await
.expect("subscribe never fails");
// Verify the structure of the response.
let event = events
.filter_map(fixtures::message::events)
.next()
.immediately()
.await
.expect("delivered stored message");
assert!(fixtures::event::message_sent(&event, &message));
}
#[tokio::test]
async fn includes_live_message() {
// Set up the environment
let app = fixtures::scratch_app().await;
let channel = fixtures::channel::create(&app, &fixtures::now()).await;
// Call the endpoint
let subscriber_creds = fixtures::login::create_with_password(&app, &fixtures::now()).await;
let subscriber = fixtures::identity::identity(&app, &subscriber_creds, &fixtures::now()).await;
let get::Response(events) =
get::handler(State(app.clone()), subscriber, None, Query::default())
.await
.expect("subscribe never fails");
// Verify the semantics
let sender = fixtures::login::create(&app, &fixtures::now()).await;
let message = fixtures::message::send(&app, &channel, &sender, &fixtures::now()).await;
let event = events
.filter_map(fixtures::message::events)
.next()
.immediately()
.await
.expect("delivered live message");
assert!(fixtures::event::message_sent(&event, &message));
}
#[tokio::test]
async fn includes_multiple_channels() {
// Set up the environment
let app = fixtures::scratch_app().await;
let sender = fixtures::login::create(&app, &fixtures::now()).await;
let channels = [
fixtures::channel::create(&app, &fixtures::now()).await,
fixtures::channel::create(&app, &fixtures::now()).await,
];
let messages = stream::iter(channels)
.then(|channel| {
let app = app.clone();
let sender = sender.clone();
let channel = channel.clone();
async move { fixtures::message::send(&app, &channel, &sender, &fixtures::now()).await }
})
.collect::<Vec<_>>()
.await;
// Call the endpoint
let subscriber_creds = fixtures::login::create_with_password(&app, &fixtures::now()).await;
let subscriber = fixtures::identity::identity(&app, &subscriber_creds, &fixtures::now()).await;
let get::Response(events) = get::handler(State(app), subscriber, None, Query::default())
.await
.expect("subscribe never fails");
// Verify the structure of the response.
let events = events
.filter_map(fixtures::message::events)
.take(messages.len())
.collect::<Vec<_>>()
.immediately()
.await;
for message in &messages {
assert!(events
.iter()
.any(|event| fixtures::event::message_sent(event, message)));
}
}
#[tokio::test]
async fn sequential_messages() {
// Set up the environment
let app = fixtures::scratch_app().await;
let channel = fixtures::channel::create(&app, &fixtures::now()).await;
let sender = fixtures::login::create(&app, &fixtures::now()).await;
let messages = vec![
fixtures::message::send(&app, &channel, &sender, &fixtures::now()).await,
fixtures::message::send(&app, &channel, &sender, &fixtures::now()).await,
fixtures::message::send(&app, &channel, &sender, &fixtures::now()).await,
];
// Call the endpoint
let subscriber_creds = fixtures::login::create_with_password(&app, &fixtures::now()).await;
let subscriber = fixtures::identity::identity(&app, &subscriber_creds, &fixtures::now()).await;
let get::Response(events) = get::handler(State(app), subscriber, None, Query::default())
.await
.expect("subscribe never fails");
// Verify the structure of the response.
let mut events = events
.filter_map(fixtures::message::events)
.filter(|event| {
future::ready(
messages
.iter()
.any(|message| fixtures::event::message_sent(event, message)),
)
});
// Verify delivery in order
for message in &messages {
let event = events
.next()
.immediately()
.await
.expect("undelivered messages remaining");
assert!(fixtures::event::message_sent(&event, message));
}
}
#[tokio::test]
async fn resumes_from() {
// Set up the environment
let app = fixtures::scratch_app().await;
let channel = fixtures::channel::create(&app, &fixtures::now()).await;
let sender = fixtures::login::create(&app, &fixtures::now()).await;
let initial_message = fixtures::message::send(&app, &channel, &sender, &fixtures::now()).await;
let later_messages = vec![
fixtures::message::send(&app, &channel, &sender, &fixtures::now()).await,
fixtures::message::send(&app, &channel, &sender, &fixtures::now()).await,
];
// Call the endpoint
let subscriber_creds = fixtures::login::create_with_password(&app, &fixtures::now()).await;
let subscriber = fixtures::identity::identity(&app, &subscriber_creds, &fixtures::now()).await;
let resume_at = {
// First subscription
let get::Response(events) = get::handler(
State(app.clone()),
subscriber.clone(),
None,
Query::default(),
)
.await
.expect("subscribe never fails");
let event = events
.filter_map(fixtures::message::events)
.next()
.immediately()
.await
.expect("delivered events");
assert!(fixtures::event::message_sent(&event, &initial_message));
event.sequence()
};
// Resume after disconnect
let get::Response(resumed) = get::handler(
State(app),
subscriber,
Some(resume_at.into()),
Query::default(),
)
.await
.expect("subscribe never fails");
// Verify the structure of the response.
let events = resumed
.filter_map(fixtures::message::events)
.take(later_messages.len())
.collect::<Vec<_>>()
.immediately()
.await;
for message in &later_messages {
assert!(events
.iter()
.any(|event| fixtures::event::message_sent(event, message)));
}
}
// This test verifies a real bug I hit developing the vector-of-sequences
// approach to resuming events. A small omission caused the event IDs in a
// resumed stream to _omit_ channels that were in the original stream until
// those channels also appeared in the resumed stream.
//
// Clients would see something like
// * In the original stream, Cfoo=5,Cbar=8
// * In the resumed stream, Cfoo=6 (no Cbar sequence number)
//
// Disconnecting and reconnecting a second time, using event IDs from that
// initial period of the first resume attempt, would then cause the second
// resume attempt to restart all other channels from the beginning, and not
// from where the first disconnection happened.
//
// This is a real and valid behaviour for clients!
#[tokio::test]
async fn serial_resume() {
// Set up the environment
let app = fixtures::scratch_app().await;
let sender = fixtures::login::create(&app, &fixtures::now()).await;
let channel_a = fixtures::channel::create(&app, &fixtures::now()).await;
let channel_b = fixtures::channel::create(&app, &fixtures::now()).await;
// Call the endpoint
let subscriber_creds = fixtures::login::create_with_password(&app, &fixtures::now()).await;
let subscriber = fixtures::identity::identity(&app, &subscriber_creds, &fixtures::now()).await;
let resume_at = {
let initial_messages = [
fixtures::message::send(&app, &channel_a, &sender, &fixtures::now()).await,
fixtures::message::send(&app, &channel_b, &sender, &fixtures::now()).await,
];
// First subscription
let get::Response(events) = get::handler(
State(app.clone()),
subscriber.clone(),
None,
Query::default(),
)
.await
.expect("subscribe never fails");
let events = events
.filter_map(fixtures::message::events)
.take(initial_messages.len())
.collect::<Vec<_>>()
.immediately()
.await;
for message in &initial_messages {
assert!(events
.iter()
.any(|event| fixtures::event::message_sent(event, message)));
}
let event = events.last().expect("this vec is non-empty");
event.sequence()
};
// Resume after disconnect
let resume_at = {
let resume_messages = [
// Note that channel_b does not appear here. The buggy behaviour
// would be masked if channel_b happened to send a new message
// into the resumed event stream.
fixtures::message::send(&app, &channel_a, &sender, &fixtures::now()).await,
fixtures::message::send(&app, &channel_a, &sender, &fixtures::now()).await,
];
// Second subscription
let get::Response(events) = get::handler(
State(app.clone()),
subscriber.clone(),
Some(resume_at.into()),
Query::default(),
)
.await
.expect("subscribe never fails");
let events = events
.filter_map(fixtures::message::events)
.take(resume_messages.len())
.collect::<Vec<_>>()
.immediately()
.await;
for message in &resume_messages {
assert!(events
.iter()
.any(|event| fixtures::event::message_sent(event, message)));
}
let event = events.last().expect("this vec is non-empty");
event.sequence()
};
// Resume after disconnect a second time
{
// At this point, we can send on either channel and demonstrate the
// problem. The resume point should before both of these messages, but
// after _all_ prior messages.
let final_messages = [
fixtures::message::send(&app, &channel_a, &sender, &fixtures::now()).await,
fixtures::message::send(&app, &channel_b, &sender, &fixtures::now()).await,
];
// Third subscription
let get::Response(events) = get::handler(
State(app.clone()),
subscriber.clone(),
Some(resume_at.into()),
Query::default(),
)
.await
.expect("subscribe never fails");
let events = events
.filter_map(fixtures::message::events)
.take(final_messages.len())
.collect::<Vec<_>>()
.immediately()
.await;
// This set of messages, in particular, _should not_ include any prior
// messages from `initial_messages` or `resume_messages`.
for message in &final_messages {
assert!(events
.iter()
.any(|event| fixtures::event::message_sent(event, message)));
}
};
}
#[tokio::test]
async fn terminates_on_token_expiry() {
// Set up the environment
let app = fixtures::scratch_app().await;
let channel = fixtures::channel::create(&app, &fixtures::now()).await;
let sender = fixtures::login::create(&app, &fixtures::now()).await;
// Subscribe via the endpoint
let subscriber_creds = fixtures::login::create_with_password(&app, &fixtures::now()).await;
let subscriber =
fixtures::identity::identity(&app, &subscriber_creds, &fixtures::ancient()).await;
let get::Response(events) =
get::handler(State(app.clone()), subscriber, None, Query::default())
.await
.expect("subscribe never fails");
// Verify the resulting stream's behaviour
app.tokens()
.expire(&fixtures::now())
.await
.expect("expiring tokens succeeds");
// These should not be delivered.
let messages = [
fixtures::message::send(&app, &channel, &sender, &fixtures::now()).await,
fixtures::message::send(&app, &channel, &sender, &fixtures::now()).await,
fixtures::message::send(&app, &channel, &sender, &fixtures::now()).await,
];
assert!(events
.filter_map(fixtures::message::events)
.filter(|event| future::ready(
messages
.iter()
.any(|message| fixtures::event::message_sent(event, message))
))
.next()
.immediately()
.await
.is_none());
}
#[tokio::test]
async fn terminates_on_logout() {
// Set up the environment
let app = fixtures::scratch_app().await;
let channel = fixtures::channel::create(&app, &fixtures::now()).await;
let sender = fixtures::login::create(&app, &fixtures::now()).await;
// Subscribe via the endpoint
let subscriber_creds = fixtures::login::create_with_password(&app, &fixtures::now()).await;
let subscriber_token =
fixtures::identity::logged_in(&app, &subscriber_creds, &fixtures::now()).await;
let subscriber =
fixtures::identity::from_token(&app, &subscriber_token, &fixtures::now()).await;
let get::Response(events) = get::handler(
State(app.clone()),
subscriber.clone(),
None,
Query::default(),
)
.await
.expect("subscribe never fails");
// Verify the resulting stream's behaviour
app.tokens()
.logout(&subscriber.token)
.await
.expect("expiring tokens succeeds");
// These should not be delivered.
let messages = [
fixtures::message::send(&app, &channel, &sender, &fixtures::now()).await,
fixtures::message::send(&app, &channel, &sender, &fixtures::now()).await,
fixtures::message::send(&app, &channel, &sender, &fixtures::now()).await,
];
assert!(events
.filter_map(fixtures::message::events)
.filter(|event| future::ready(
messages
.iter()
.any(|message| fixtures::event::message_sent(event, message))
))
.next()
.immediately()
.await
.is_none());
}
|